Add MySQL support to backfill script #2081
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2081 +/- ##
===========================================
- Coverage 66.46% 48.95% -17.51%
===========================================
Files 92 80 -12
Lines 9258 6639 -2619
===========================================
- Hits 6153 3250 -2903
- Misses 2359 2985 +626
+ Partials 746 404 -342
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cmurphy
force-pushed
the
mysql-backfill
branch
7 times, most recently
from
2e50cd7 to
0753006
Compare
cmurphy
changed the title
cmurphy
force-pushed
the
mysql-backfill
branch
2 times, most recently
from
f3d78c4 to
f94da75
Compare
| run: echo "GOVERSION=$(cat Dockerfile|grep golang | awk ' { print $2 } ' | cut -d '@' -f 1 | cut -d ':' -f 2 | uniq)" >> $GITHUB_ENV | ||
| - uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0 | ||
| with: | ||
| go-version: ${{ env.GOVERSION }} |
There was a problem hiding this comment.
Can we use go-version-file: go.mod instead? Dockerfile and go.mod should stay in sync.
There was a problem hiding this comment.
I can, but that would make this job inconsistent with every other workflow in rekor, fulcio, and cosign, for example line 89 above. Do you want this changed everywhere?
There was a problem hiding this comment.
Let's keep it consistent, we can change it in a follow up.
docker-compose.backfill-test.yml
Outdated
| @@ -0,0 +1,61 @@ | |||
| # | |||
| # Copyright 2022 The Sigstore Authors. | |||
Signed-off-by: Colleen Murphy <colleenmurphy@google.com>
Rename backfill-redis to backfill-index and add support for when MySQL is used as the index storage backend. Some Redis-specific parameters are renamed to clearly differentiate them from MySQL parameters. MySQL connection parameters mirror the rekor-server paramters, using a single --dsn flag instead of separate host, port, password, etc flags. Signed-off-by: Colleen Murphy <colleenmurphy@google.com>
Signed-off-by: Colleen Murphy <colleenmurphy@google.com>
Rename backfill-redis to backfill-index and add support for when MySQL
is used as the index storage backend.
Some Redis-specific parameters are renamed to clearly differentiate them
from MySQL parameters. MySQL connection parameters mirror the
rekor-server paramters, using a single --dsn flag instead of separate
host, port, password, etc flags.
To do:
Summary
Release Note
Documentation