Rework Rekor module structure and enable doc tests #145
+95
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the next commit to pass the cargo doc tests, as that commit brings in the rekor module test, which was not being run previously. Signed-off-by: Lily Sturmann <lsturman@redhat.com>
This commit: - Moves lib.rs to mod.rs according to Rust convention (note: this also brings in the doc test for the rekor module, which was not being run previously) - Updates clap-related arguments in rekor/mod.rs Signed-off-by: Lily Sturmann <lsturman@redhat.com>
flavio
approved these changes
Oct 19, 2022
flavio
added a commit
to flavio/sigstore-rs
that referenced
this pull request
Oct 21, 2022
Fixes ====== * rustls should not require openssl by (sigstore#146) Others ====== * Rework Rekor module structure and enable doc tests (sigstore#145) Contributors ============ * Flavio Castelli (@flavio) * Lily Sturmann (@lkatalin) Signed-off-by: Flavio Castelli <fcastelli@suse.com>
avery-blanchard
pushed a commit
to avery-blanchard/sigstore-rs
that referenced
this pull request
Oct 21, 2022
Fixes ====== * rustls should not require openssl by (sigstore#146) Others ====== * Rework Rekor module structure and enable doc tests (sigstore#145) Contributors ============ * Flavio Castelli (@flavio) * Lily Sturmann (@lkatalin) Signed-off-by: Flavio Castelli <fcastelli@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This moves the Rekor module's
lib.rstomod.rsaccording to Rust convention. This also enables the doc tests to be run on the Rekor module. Since that test was not being run before, doing this exposed errors, which are also fixed in this PR.Fixes #144