dependency cleanup #390
Merged
dependency cleanup #390
+51
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're a library, unless strictly needed, we should not require major.minor.patch level versions of dependencies. This is especially true for dependencies like `tokio`, where we should limit ourselves to the `major` version only. Signed-off-by: Flavio Castelli <fcastelli@suse.com>
Remove the `chrono` dev-dependency, it's already a top level dependency. Signed-off-by: Flavio Castelli <fcastelli@suse.com>
Update dev-dependencies to latest versions Signed-off-by: Flavio Castelli <fcastelli@suse.com>
Bump dependencies to latest version. Signed-off-by: Flavio Castelli <fcastelli@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed our Cargo.toml file needed some love:
tokio.dependenciesanddev-dependenciessections.dev-dependencieswere outdated.dependencieswere outdated.About the
dev-dependenciesanddependencybumps. I'm concerned, since dependabot should be taking care of this. I've double checked our configuration and everything seems fine. I'm really puzzled, since we got some dependabot PRs, but we missed a lot of updates.