-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade to go 1.20.1 #245
upgrade to go 1.20.1 #245
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Ah, one unit test failure, looks like you need a different way to seed rand? |
Oh you probably need to update the expected test results, I guess the new implementation of random doesn't result in a the same deterministic order (which is kinda strange if true?) |
I saw, did not have time yesterday to fix it, will try this weekend |
Codecov Report
@@ Coverage Diff @@
## main #245 +/- ##
==========================================
- Coverage 52.66% 52.53% -0.14%
==========================================
Files 19 19
Lines 1143 1146 +3
==========================================
Hits 602 602
- Misses 483 486 +3
Partials 58 58
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@haydentherapper let me know if you agree with the rand change. PTAL |
4752270
to
1589b82
Compare
@haydentherapper PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cpanato could you rebase, then the tests should pass?
Signed-off-by: cpanato <ctadeu@gmail.com>
Signed-off-by: cpanato <ctadeu@gmail.com>
Signed-off-by: cpanato <ctadeu@gmail.com>
Signed-off-by: cpanato <ctadeu@gmail.com>
@haydentherapper done, PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Summary