BA-2192: mobile features into packages #198
Conversation
|
WalkthroughThis pull request implements several updates across the codebase. A new script file is introduced to copy TypeScript declaration files using asynchronous file operations and recursive directory traversal. The authentication package sees its version bumped and dependency versions updated explicitly, while the components package undergoes configuration changes including ESLint adjustments, modifications to .gitignore entries, updated import paths in Storybook mocks and decorators, and comprehensive changelog and documentation updates detailing a reorganization of the package structure and build process. Changes
Sequence Diagram(s)sequenceDiagram
participant Main as copyDTS()
participant Walker as walk() Generator
participant FS as File System
participant Log as Logger
Main->>Walker: Start directory traversal in 'tmp-dts'
Walker-->>Main: Yield file path (if .d.ts)
Main->>FS: Create target directory (recursive)
Main->>FS: Copy file to destination ('dist')
FS-->>Main: Confirm file copied
Main->>Log: Log success message
Main-->>Walker: Iterate over remaining files (handle errors if any)
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 ESLint
packages/components/.eslintrc.jsOops! Something went wrong! :( ESLint: 8.57.1 Error: Cannot read config file: /packages/components/.eslintrc.js
packages/components/.storybook/__mocks__/navigation.tsxOops! Something went wrong! :( ESLint: 8.57.1 Error: Cannot read config file: /packages/components/.eslintrc.js
packages/components/.storybook/__mocks__/theme.tsOops! Something went wrong! :( ESLint: 8.57.1 Error: Cannot read config file: /packages/components/.eslintrc.js
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
anicioalexandre
force-pushed
the
BA-2192-mobile-features-to-packages
branch
from
359cbd8 to
09d7dca
Compare
anicioalexandre
requested review from
deboracosilveira and
priscilladeroode
as code owners
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
♻️ Duplicate comments (1)
packages/components/.storybook/decorators/withProviders.tsx (1)
1-4:⚠️ Potential issueFix module resolution and approve import cleanup.
Good:
- Removed unused
useEffectimport- Split imports for better organization
Issue:
- Same module resolution error as in theme.ts for
@baseapp-frontend/design-system/*imports
🧹 Nitpick comments (3)
packages/components/CHANGELOG.md (1)
5-10: Detailed "Major Changes" Section – Well Documented
The “Major Changes” section clearly lists the key structural updates (folder reorganization, build toolchain changes, and migration of native components). The bullet points are succinct; however, consider verifying that the descriptions fully capture all critical updates for internal and external users of the package. A minor refinement could be to consistently use active voice (e.g., “Reorganized module code…”)..scripts/copy-dts.js (1)
9-19: Consider adding error handling in the walk generator.While the implementation is correct, it could benefit from error handling for directory access issues.
async function* walk(dir) { + try { const entries = await readdir(dir, { withFileTypes: true }) for (const entry of entries) { const res = path.resolve(dir, entry.name) if (entry.isDirectory()) { yield* walk(res) } else { yield res } } + } catch (error) { + console.error(`Error walking directory ${dir}:`, error) + throw error + } }packages/components/README.md (1)
79-79: Fix grammar in features list.There's a grammatical error in the sentence.
-generating both ESM and CJS outputs and others features provided by tsup. +generating both ESM and CJS outputs and other features provided by tsup.🧰 Tools
🪛 LanguageTool
[uncategorized] ~79-~79: “Other things” (plural) doesn’t require “other” to be in plural.
Context: ...generating both ESM and CJS outputs and others features provided by tsup. In the end, the hybr...(OTHERS)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (79)
packages/components/__generated__/ActivityLogsFragment.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/ActivityLogsPaginationQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/ActivityLogsQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/AddProfilePopoverUserQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/AllProfilesListFragment.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/AllProfilesListPaginationQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/ArchiveChatRoomMutation.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/BlockToggleFragment.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/BlockToggleMutation.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/ChangeUserRoleMutation.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/ChatRoomMessagesListPaginationQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/ChatRoomParticipantsPaginationQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/ChatRoomQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/ChatRoomsQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/CommentCreateMutation.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/CommentDeleteMutation.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/CommentItemRefetchQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/CommentItemWithQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/CommentItem_comment.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/CommentItem_target.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/CommentPinMutation.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/CommentUpdateMutation.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/CommentsForTestingQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/CommentsFragment.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/CommentsListPaginationQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/CommentsListWithQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/CommentsList_comments.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/CommentsRefetchQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/CommentsSubscription.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/CommentsUpdateWithQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/CommentsWithQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/CreateChatRoomMutation.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/FollowToggleMutation.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/FollowToggleUpdatableFragment.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/GroupDetailsQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/GroupTitleFragment.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/LastMessageFragment.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/MemberItemFragment.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/MembersListFragment.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/MessageItemFragment.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/MessageUpdateMutation.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/MessagesListFragment.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/NotificationItemFragment.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/NotificationItemWithQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/NotificationUserMenuFragment.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/NotificationsListFragment.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/NotificationsListQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/NotificationsMarkAllAsReadMutation.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/NotificationsMarkAsReadMutation.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/NotificationsPopoverQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/OrganizationCreateMutation.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/ProfileComponentFragment.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/ProfileItemFragment.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/ProfileUpdateMutation.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/ProfilesListFragment.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/ProfilesListQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/ReactionButtonMutation.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/ReactionButtonWithQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/ReactionButton_target.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/ReadMessagesMutation.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/RoomFragment.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/RoomTitleFragment.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/RoomsListFragment.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/SendMessageMutation.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/TitleFragment.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/UnreadChatMutation.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/UnreadMessagesCountFragment.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/UpdateChatRoomMutation.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/UserMembersListFragment.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/UserMembersListPaginationQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/UserProfileQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/chatRoomsPaginationQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/notificationsListRefetchable.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/profilesListRefetchable.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/useMessageCountUpdateSubscription.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/useMessagesListSubscription.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/useNotificationsSubscription.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/useRoomListSubscription.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/userMembersListPaginationRefetchable.graphql.tsis excluded by!**/__generated__/**
📒 Files selected for processing (10)
.scripts/copy-dts.js(1 hunks)packages/authentication/CHANGELOG.md(1 hunks)packages/authentication/package.json(2 hunks)packages/components/.eslintrc.js(1 hunks)packages/components/.gitignore(1 hunks)packages/components/.storybook/__mocks__/navigation.tsx(1 hunks)packages/components/.storybook/__mocks__/theme.ts(1 hunks)packages/components/.storybook/decorators/withProviders.tsx(1 hunks)packages/components/CHANGELOG.md(1 hunks)packages/components/README.md(1 hunks)
✅ Files skipped from review due to trivial changes (4)
- packages/components/.storybook/mocks/navigation.tsx
- packages/components/.eslintrc.js
- packages/components/.gitignore
- packages/authentication/CHANGELOG.md
🧰 Additional context used
🪛 LanguageTool
packages/components/README.md
[uncategorized] ~79-~79: “Other things” (plural) doesn’t require “other” to be in plural.
Context: ...generating both ESM and CJS outputs and others features provided by tsup. In the end, the hybr...
(OTHERS)
🪛 GitHub Actions: Main Workflow
packages/components/.storybook/__mocks__/theme.ts
[error] 1-1: Cannot find module '@baseapp-frontend/design-system/providers/web' or its corresponding type declarations.
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (javascript)
🔇 Additional comments (6)
packages/components/CHANGELOG.md (2)
3-4: Major Version Header is Clear and Concise
The new major version “1.0.0” is prominently declared at the top of the changelog. This aligns well with semantic versioning practices and sets the stage for the major changes described below.
11-18: "Patch Changes" Dependency Updates are Accurate
The “Patch Changes” section for version 1.0.0 lists updated dependency versions in a clear and accessible format. Ensure that these version upgrades have corresponding release notes elsewhere (if applicable) so that users can easily reference details on the improvements or fixes provided. Overall, this segment is well structured..scripts/copy-dts.js (1)
1-8: LGTM! Good use of promisify for async operations.The code correctly promisifies the necessary fs functions for async file operations.
packages/authentication/package.json (2)
26-26: Verify React version compatibility.React 18.3.1 seems to be a future version that might not be released yet.
17-22: Verify compatibility between dependency versions.Some dependencies have undergone major version updates. Please verify compatibility:
@tanstack/react-queryv5.45.1 is a major version updatezodv3.24.1 might have breaking changespackages/components/README.md (1)
31-81: Excellent documentation of the build process!The build process documentation is thorough and well-structured, clearly explaining:
- The hybrid pipeline approach
- Each step in the process
- Pros and cons
- Alternatives considered
🧰 Tools
🪛 LanguageTool
[uncategorized] ~79-~79: “Other things” (plural) doesn’t require “other” to be in plural.
Context: ...generating both ESM and CJS outputs and others features provided by tsup. In the end, the hybr...(OTHERS)
anicioalexandre
force-pushed
the
BA-2192-mobile-features-to-packages
branch
from
ee9df0e to
4dc7aa0
Compare
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/components/README.md (1)
29-81: Comprehensive Build Process Documentation
The added “Build Process” section thoroughly outlines the hybrid pipeline, detailing each step—from Babel transformations and tsup bundling to TypeScript declaration handling. This explanation is valuable for users to understand the trade-offs and advantages of using multiple tools.A couple of minor points for refinement:
- At line 79, the phrase “and others features provided by tsup” should be corrected to “and other features provided by tsup” for grammatical accuracy.
- It might be beneficial to include links or references to the official documentation of Babel, tsup, and tsc, so that users can dive deeper if needed.
Overall, these additions provide strong context about the build workflow and architectural decisions.
🧰 Tools
🪛 LanguageTool
[uncategorized] ~79-~79: “Other things” (plural) doesn’t require “other” to be in plural.
Context: ...generating both ESM and CJS outputs and others features provided by tsup. In the end, the hybr...(OTHERS)
packages/authentication/package.json (1)
33-47: DevDependencies Version Precision & Consistency
The devDependencies have been updated to explicit versions—this includes tools such as "@faker-js/faker" (now "^9.0.3"), testing libraries, type definitions, and TypeScript-related packages. This move away from catalog-based versioning improves clarity and build reproducibility.Note: There is a minor inconsistency where "@faker-js/faker" uses the caret (^) operator while the other dependencies are pinned to an exact version. If the intent is to have a consistent versioning strategy across all devDependencies, consider aligning this notation.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (79)
packages/components/__generated__/ActivityLogsFragment.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/ActivityLogsPaginationQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/ActivityLogsQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/AddProfilePopoverUserQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/AllProfilesListFragment.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/AllProfilesListPaginationQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/ArchiveChatRoomMutation.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/BlockToggleFragment.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/BlockToggleMutation.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/ChangeUserRoleMutation.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/ChatRoomMessagesListPaginationQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/ChatRoomParticipantsPaginationQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/ChatRoomQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/ChatRoomsQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/CommentCreateMutation.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/CommentDeleteMutation.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/CommentItemRefetchQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/CommentItemWithQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/CommentItem_comment.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/CommentItem_target.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/CommentPinMutation.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/CommentUpdateMutation.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/CommentsForTestingQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/CommentsFragment.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/CommentsListPaginationQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/CommentsListWithQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/CommentsList_comments.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/CommentsRefetchQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/CommentsSubscription.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/CommentsUpdateWithQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/CommentsWithQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/CreateChatRoomMutation.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/FollowToggleMutation.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/FollowToggleUpdatableFragment.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/GroupDetailsQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/GroupTitleFragment.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/LastMessageFragment.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/MemberItemFragment.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/MembersListFragment.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/MessageItemFragment.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/MessageUpdateMutation.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/MessagesListFragment.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/NotificationItemFragment.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/NotificationItemWithQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/NotificationUserMenuFragment.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/NotificationsListFragment.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/NotificationsListQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/NotificationsMarkAllAsReadMutation.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/NotificationsMarkAsReadMutation.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/NotificationsPopoverQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/OrganizationCreateMutation.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/ProfileComponentFragment.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/ProfileItemFragment.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/ProfileUpdateMutation.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/ProfilesListFragment.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/ProfilesListQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/ReactionButtonMutation.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/ReactionButtonWithQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/ReactionButton_target.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/ReadMessagesMutation.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/RoomFragment.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/RoomTitleFragment.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/RoomsListFragment.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/SendMessageMutation.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/TitleFragment.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/UnreadChatMutation.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/UnreadMessagesCountFragment.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/UpdateChatRoomMutation.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/UserMembersListFragment.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/UserMembersListPaginationQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/UserProfileQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/chatRoomsPaginationQuery.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/notificationsListRefetchable.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/profilesListRefetchable.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/useMessageCountUpdateSubscription.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/useMessagesListSubscription.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/useNotificationsSubscription.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/useRoomListSubscription.graphql.tsis excluded by!**/__generated__/**packages/components/__generated__/userMembersListPaginationRefetchable.graphql.tsis excluded by!**/__generated__/**
📒 Files selected for processing (10)
.scripts/copy-dts.js(1 hunks)packages/authentication/CHANGELOG.md(1 hunks)packages/authentication/package.json(2 hunks)packages/components/.eslintrc.js(1 hunks)packages/components/.gitignore(1 hunks)packages/components/.storybook/__mocks__/navigation.tsx(1 hunks)packages/components/.storybook/__mocks__/theme.ts(1 hunks)packages/components/.storybook/decorators/withProviders.tsx(1 hunks)packages/components/CHANGELOG.md(1 hunks)packages/components/README.md(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (7)
- packages/components/.gitignore
- packages/authentication/CHANGELOG.md
- .scripts/copy-dts.js
- packages/components/.eslintrc.js
- packages/components/.storybook/mocks/navigation.tsx
- packages/components/.storybook/decorators/withProviders.tsx
- packages/components/.storybook/mocks/theme.ts
🧰 Additional context used
🪛 LanguageTool
packages/components/README.md
[uncategorized] ~79-~79: “Other things” (plural) doesn’t require “other” to be in plural.
Context: ...generating both ESM and CJS outputs and others features provided by tsup. In the end, the hybr...
(OTHERS)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Build
- GitHub Check: Lint
🔇 Additional comments (15)
packages/components/CHANGELOG.md (10)
3-3: Major Version Bump to 1.0.0 is clearly indicated.
This new version header signals a major update with significant structural changes as described in the PR objectives.
5-5: Clear "Major Changes" Section Header.
The header effectively segregates the major changes from other updates, improving the readability and structure of the changelog.
7-7: Reorganization of Module Folders.
The changelog documents the reorganization intocommon,native, andwebfolders. This structural change supports multi-platform code separation. Please ensure that related documentation and internal references (if any) are updated accordingly.
8-8: Updated Build Tooling.
Specifying that the package code is now transpiled and bundled usingbabel,tsup, andtscclarifies the new build process. It is important to verify that all related configuration files (e.g., babel or tsup configs) reflect these changes.
9-9: Migration of Native Profile Components.
The note on migrating nativeprofilecomponents from the template is crucial for mobile feature integration. Ensure that these components have been thoroughly tested post-migration to confirm full functionality.
13-13: Summary of Dependency Updates.
This bullet point clearly introduces the updated dependencies under the patch changes section. It helps track what has changed for future reference.
14-14: Design-System Dependency Update.
The design system dependency is set to version 1.0.0. Verify that any inter-package integrations using this dependency are compatible with the updates.
15-15: Utils Dependency Update.
The utils package has been updated to version 3.1.3 as indicated. Confirm that this update does not break any utility functions leveraged in the components package.
16-16: Authentication Dependency Update.
The authentication dependency is now at version 4.1.4. It is important to ensure that any authentication flows or integrations in the components package continue to work as expected.
17-17: GraphQL Dependency Update.
The changelog shows that the GraphQL dependency has been bumped to version 1.2.4. Please ensure that any GraphQL queries or mutations used within the package are compatible with this updated version.packages/components/README.md (2)
21-21: Updated Package Terminology for Clarity
The description now uses “modules” instead of “components” (e.g. “BaseApp modules such ascomments,notifications,messagesandnavigations”) which aligns with the restructuring goals for this package. This clearly differentiates the internal organization from the externally exposed package name.
24-27: Revised Storybook Command Usage
The code block now includes a new comment (“# at root level”) and the command has been updated to “pnpm storybook --filter components”. This update reflects the shift to pnpm and specifying a filter. One point to verify is the consistency between the new terminology (modules) mentioned in the description and the filter key (“components”) used in the command. Please confirm that this discrepancy is intentional based on your package naming conventions.packages/authentication/package.json (3)
4-4: Version Bump Update
The package version has been updated to "4.1.4", reflecting the intended patch update. Please verify that the CHANGELOG and any related release notes have been updated accordingly.
17-22: Explicit Dependency Versions
The dependency entries for "@hookform/resolvers", "@tanstack/react-query", "jotai", "js-cookie", "react-hook-form", and "zod" have been switched from catalog-based placeholders to explicit versions. This change improves reproducibility and clarity in dependency management. Ensure that these specified versions are fully compatible with the rest of the codebase and pass all integration tests.
26-26: Peer Dependency Update
The React peer dependency has been updated to "18.3.1" from the previous catalog notation. This explicit version specification should help downstream consumers verify compatibility more easily. Please confirm that all dependent projects are compatible with this version.
componentspackage update -v 1.0.0modulecode into folders,commonfor multi-platform code,nativefor native code andwebfor web code.babel,tsupandtsc.profilecomponents from the template into this package.design-systempackage update -v 1.0.0components,hooks,layouts,providers,stylesandutilsinto folders,commonfor multi-platform code,nativefor native code andwebfor web code.tsupandtsc.design-sytemcomponents from the template into this package.configpackage update -v 2.1.11.eslintrc-with-restricted-pathseslint file to be able to restric imports from certain folders.Summary by CodeRabbit
New Features
Documentation
Chores
.gitignoreto improve file management during development.