Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizing toolbar #1377

Closed
PeterC-DLS opened this issue Mar 6, 2023 · 5 comments
Closed

Customizing toolbar #1377

PeterC-DLS opened this issue Mar 6, 2023 · 5 comments
Labels
epic Issue that will need to be split up later on

Comments

@PeterC-DLS
Copy link
Contributor

PeterC-DLS commented Mar 6, 2023

Is your feature request related to a problem?

We have customized some of the toolbar controls to group them together into modal dialogue boxes and move others to the overflow menu.

colormap-modal

Requested solution or feature

To do so, we require some minor changes to existing toolbar components

  1. Allow children to be initially added to the overflow menu
  2. Export some components
  3. Allow children to included in a toggle button
@axelboc
Copy link
Contributor

axelboc commented Mar 6, 2023

Thanks @PeterC-DLS, we'll look into it. Some initial thoughts:

  1. I wonder whether the responsive toolbar / overflow menu is the right approach for you, as it seems you just want a way to group less-used controls in a menu. Would a static Menu component of sorts suit your needs better?
  2. Shouldn't be a problem.
  3. Can you please expand a little on what kind of children you'd like to include in the toggle button? Maybe we can cover your use case better by rethinking the props of the component?

@PeterC-DLS
Copy link
Contributor Author

Thanks, Axel. This is what we have at the moment:
colormap-tools

  1. I think a static menu is fine but then in more crowded situations, a 2nd menu may be confusing.
  2. Great.
  3. Actually, this is not needed any longer as I moved away from re-using toggle button to the vanilla buttion for the ColorMapOption button in the screenshot.

@axelboc
Copy link
Contributor

axelboc commented Mar 6, 2023

  1. Makes sense. I could see a pattern where static menus would merge into the overflow menu, as demonstrated here: https://www.telerik.com/kendo-angular-ui/components/toolbar/responsive-toolbar/ — maybe too complicated, I'll have to think about it more. Re-using the overflow menu is definitely easier for the time being.

@axelboc
Copy link
Contributor

axelboc commented Jul 26, 2023

Closing this as resolved now that DomainControls and DomainSlider are exported in main (as a reminder, the old DomainSlider export is now called DomainWidget). I won't go further on the idea of having static menus that merge into the overflow menu, at least for the time being. We can open a new issue when the time comes if the idea becomes more relevant.

I probably won't publish the next major release until September, but in the meantime I've published beta version 9.0.0-beta.0 and updated the documentation site. Feel free to try it out and to let me know if the new exports meet your needs. 😉

@axelboc axelboc closed this as completed Jul 26, 2023
@PeterC-DLS
Copy link
Contributor Author

Thanks for the refactor. We are maintaining a fork so will have a look at updating that to reduce our divergence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic Issue that will need to be split up later on
Projects
None yet
Development

No branches or pull requests

2 participants