Refactor Selector
API and implement ComplexVisTypeSelector
#1652
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING
optionComponent
prop ofSelector
with a cleanerrenderOption
prop. This simplifies a few things, including removing the need for dedicated option components (ScaleOption
andColorMapOption
).ColorMapOption
, which was exported in the lib to address Customizing toolbar #1377, with a new component calledColorMapGradient
that takes care only of rendering a little gradient preview for a given color map (which should in fact cover more customisation use cases).NEW FEATURE
ComplexVisTypeSelector
(in line withColorMapSelector
andScaleSelector
) to reduce duplication, and I export it in the lib;ComplexVisType
to the shared package and I export it in the lib; I also replace its values and stop relying on them for display purposes (axis label, plot title, selector options), as this seemed very brittle and prevented displaying different labels in different places.