Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualize scalar compounds #1674

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Visualize scalar compounds #1674

merged 2 commits into from
Jun 24, 2024

Conversation

axelboc
Copy link
Contributor

@axelboc axelboc commented Jun 19, 2024

Fix #1649

image

  • I've made the Compound visualization its own thing (it still uses MatrixVis internally, but the tab shows "Compound").
  • I'm reusing CompoundVisContainer and MappedCompoundVis (previously CompoundMatrixVisContainer and MappedCompoundMatrixVis) so they now handle both scalar and array datasets.

@axelboc
Copy link
Contributor Author

axelboc commented Jun 19, 2024

/approve

@axelboc axelboc requested a review from loichuder June 19, 2024 07:31
@axelboc axelboc merged commit e91db90 into main Jun 24, 2024
8 checks passed
@axelboc axelboc deleted the scalar-compound branch June 24, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show field names in Scalar view for Compound Datatypes
2 participants