Lint and update dependencies #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
commented
Apr 7, 2021
source/lib/repositories-service.js
Outdated
Comment on lines
38
to
40
| tree[owner] = Object.assign(tree[owner] || {}, { | ||
| [repository]: Boolean(stored && stored[owner] && stored[owner][repository]) | ||
| }); |
There was a problem hiding this comment.
.reduce brought us to do unspeakable things
Suggested change
| tree[owner] = Object.assign(tree[owner] || {}, { | |
| [repository]: Boolean(stored && stored[owner] && stored[owner][repository]) | |
| }); | |
| tree[owner] = tree[owner] || {}; | |
| tree[owner][repository] = Boolean(stored && stored[owner] && stored[owner][repository]); |
Or this?
Suggested change
| tree[owner] = Object.assign(tree[owner] || {}, { | |
| [repository]: Boolean(stored && stored[owner] && stored[owner][repository]) | |
| }); | |
| tree[owner] = tree[owner] || {}; | |
| tree[owner][repository] = Boolean(stored?.[owner]?.[repository]); |
Reading the code, however, it seems that this code is wrong in many parts. stored is never null nor empty since it gets the default options.
There was a problem hiding this comment.
It'll have to be done separately because this branch is on Node 11
Merged
sindresorhus
reviewed
Apr 7, 2021
Non-red already means valid
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will help fix #251
Follows and is based on #252
Untested but it looks equivalent