Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to skip file production #99

Closed
wants to merge 1 commit into from
Closed

Add feature to skip file production #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions japicmp-maven-plugin/src/main/java/japicmp/maven/JApiCmpMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,20 @@ Optional<XmlOutput> executeWithParameters(PluginParameters pluginParameters, Mav
try {
File jApiCmpBuildDir = createJapiCmpBaseDir(pluginParameters);
String diffOutput = generateDiffOutput(jApiClasses, options);
if (parameter.isSkipNoChange()) {
boolean noModif = true;
for ( JApiClass curr : jApiClasses) {
if (curr.getChangeStatus() != JApiChangeStatus.UNCHANGED) {
noModif =false;
break;
}
}
if (noModif) {
getLog().info("Skip no change ");
return Optional.absent();
}
}

createFileAndWriteTo(diffOutput, jApiCmpBuildDir, mavenParameters);
XmlOutput xmlOutput = generateXmlOutput(jApiClasses, jApiCmpBuildDir, options, mavenParameters, pluginParameters);
if (pluginParameters.isWriteToFiles()) {
Expand Down Expand Up @@ -299,8 +313,15 @@ private String generateDiffOutput(List<JApiClass> jApiClasses, Options options)

private XmlOutput generateXmlOutput(List<JApiClass> jApiClasses, File jApiCmpBuildDir, Options options, MavenParameters mavenParameters, PluginParameters pluginParameters) throws IOException, MojoFailureException {
String filename = createFilename(mavenParameters);
options.setXmlOutputFile(Optional.of(jApiCmpBuildDir.getCanonicalPath() + File.separator + filename + ".xml"));
options.setHtmlOutputFile(Optional.of(jApiCmpBuildDir.getCanonicalPath() + File.separator + filename + ".html"));

if (parameter.isSkipHtml() == false)
{
options.setHtmlOutputFile(Optional.of(jApiCmpBuildDir.getCanonicalPath() + File.separator + filename + ".html"));
}
if (parameter.isSkipXml() == false) {
options.setXmlOutputFile(Optional.of(jApiCmpBuildDir.getCanonicalPath() + File.separator + filename + ".xml"));
}

SemverOut semverOut = new SemverOut(options, jApiClasses);
XmlOutputGeneratorOptions xmlOutputGeneratorOptions = new XmlOutputGeneratorOptions();
xmlOutputGeneratorOptions.setCreateSchemaFile(true);
Expand Down
37 changes: 37 additions & 0 deletions japicmp-maven-plugin/src/main/java/japicmp/maven/Parameter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,19 @@ public class Parameter {
private String includeSynthetic;
private String ignoreMissingClasses;
private String skipPomModules;

//skip generation of outputfile generation if flag is set to true
@org.apache.maven.plugins.annotations.Parameter(required = false)
private boolean skipNoChange;

// skip XML file production
@org.apache.maven.plugins.annotations.Parameter(required = false)
private boolean skipXml;

// skip HTML file production
@org.apache.maven.plugins.annotations.Parameter(required = false)
private boolean skipHtml;

@org.apache.maven.plugins.annotations.Parameter(required = false)
private String htmlStylesheet;
@org.apache.maven.plugins.annotations.Parameter(required = false)
Expand Down Expand Up @@ -109,6 +122,30 @@ public void setSkipPomModules(String skipPomModules) {
this.skipPomModules = skipPomModules;
}

public boolean isSkipNoChange() {
return skipNoChange;
}

public void setSkipNoChange(boolean skipNoChange) {
this.skipNoChange = skipNoChange;
}

public boolean isSkipXml() {
return skipXml;
}

public void setSkipXml(boolean skipXml) {
this.skipXml = skipXml;
}

public boolean isSkipHtml() {
return skipHtml;
}

public void setSkipHtml(boolean skipHtml) {
this.skipHtml = skipHtml;
}

public String getHtmlStylesheet() {
return htmlStylesheet;
}
Expand Down