Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge test_probabilistic_metrics into TestAllDistrMetrics, fixes#398 #513

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JahnaviDhanaSri
Copy link

Reference Issues/PRs

#398

What does this implement/fix? Explain your changes.

merged test_probabilistic_metrics into TestAllDistrMetrics

Does your contribution introduce a new dependency? If yes, which one?

No

What should a reviewer concentrate their feedback on?

Did you add any tests for the change?

Any other comments?

PR checklist

For all contributions
  • I've added myself to the list of contributors with any new badges I've earned :-)
    How to: add yourself to the all-contributors file in the skpro root directory (not the CONTRIBUTORS.md). Common badges: code - fixing a bug, or adding code logic. doc - writing or improving documentation or docstrings. bug - reporting or diagnosing a bug (get this plus code if you also fixed the bug in the PR).maintenance - CI, test framework, release.
    See here for full badge reference
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.
For new estimators
  • I've added the estimator to the API reference - in docs/source/api_reference/taskname.rst, follow the pattern.
  • I've added one or more illustrative usage examples to the docstring, in a pydocstyle compliant Examples section.
  • If the estimator relies on a soft dependency, I've set the python_dependencies tag and ensured
    dependency isolation, see the estimator dependencies guide.

@fkiraly fkiraly added enhancement module:tests test framework functionality - only framework, excl specific tests labels Jan 23, 2025
@JahnaviDhanaSri
Copy link
Author

Hi @fkiraly, I have raised the pull request could you please review it.

Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please explain what you are doing here? I was assuming this was still a work in progress.

For example:

  • the original tests still exist in their original place
  • the new tests do not use the dispatch structure from the test class, you loop manually over the classes still
  • I am not sure if this will work at all, given that the interval/quantile metrics follow a different interface than the probabilistic ones. Have you thought about new class vs using the one for distribution metrics?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement module:tests test framework functionality - only framework, excl specific tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants