Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix]: Fix typo in w1d6 #75

Merged
merged 1 commit into from
May 13, 2024
Merged

[fix]: Fix typo in w1d6 #75

merged 1 commit into from
May 13, 2024

Conversation

Gleiphir2769
Copy link
Contributor

"two" things -> "three" things

You will need to modify `LSMStorageInner::force_flush_next_imm_memtable` and `MemTable::flush`. In `LSMStorageInner::open`, you will need to create the LSM database directory if it does not exist. To flush a memtable to the disk, we will need to do two things:
* Select a memtable to flush.
* Create an SST file corresponding to a memtable.
* Remove the memtable from the immutable memtable list and add the SST file to L0 SSTs.

@skyzh skyzh merged commit c4d5440 into skyzh:main May 13, 2024
darkjh pushed a commit to darkjh/mini-lsm that referenced this pull request Aug 13, 2024
Co-authored-by: shenjiaqi.2769 <shenjiaqi.2769@bytedance.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants