Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong docu on interceptors #314

Closed
svenhaag opened this issue May 25, 2020 · 1 comment · Fixed by #315
Closed

Wrong docu on interceptors #314

svenhaag opened this issue May 25, 2020 · 1 comment · Fixed by #315
Milestone

Comments

@svenhaag
Copy link

svenhaag commented May 25, 2020

Hi, I think there is a bug in the interceptors documentation at:
https://github.com/smallrye/smallrye-config/blob/1.8.0/doc/modules/ROOT/pages/interceptors/interceptors.adoc#built-in-interceptors

It says:

None of the interceptors is registered by default.

But the default Config adds all the awesome new stuff. See:
io.smallrye.config.SmallRyeConfigFactory.Default.

configProviderResolver.getBuilder().forClassLoader(classLoader)
                    .addDefaultSources()
                    .addDefaultInterceptors()
                    .addDiscoveredSources()
                    .addDiscoveredConverters()
                    .addDiscoveredInterceptors()
                    .build();
@radcortez
Copy link
Member

Thanks! I guess I forgot to change it. I'll fix it.

radcortez added a commit to radcortez/smallrye-config that referenced this issue May 25, 2020
@radcortez radcortez added this to the 1.8.1 milestone May 25, 2020
@radcortez radcortez linked a pull request May 25, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants