Use config ordinal to determine which config style to use when injecting a list, between comma-separated and indexed #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing a list, between comma-separated and indexed
|
Can you explain this heuristic? There is no doc change and it's not clear what's going on here. |
|
Added a description. Sorry for not being transparent. |
This was referenced Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #1202, we changed the priority order when selecting between a comma-separated value or indexed name format to populate a Collection. We did this to make things consistent because the comma-separated format only works for plain types, and if we require to configure a list group, it can only be expressed with the indexed format.
This was a breaking change that was not well received, so in #1266, we modified the APIs to take into account the source ordinal, meaning that we use the ordinal of the source to determine which to use, if both are available.
This PR adds the same behaviour to the injection producer.