Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in secret-keys.md #807

Merged
merged 1 commit into from
Aug 31, 2022
Merged

Fix typo in secret-keys.md #807

merged 1 commit into from
Aug 31, 2022

Conversation

gsmet
Copy link
Contributor

@gsmet gsmet commented Aug 31, 2022

No description provided.

@gsmet
Copy link
Contributor Author

gsmet commented Aug 31, 2022

BTW, the edit link on the website is broken.

It points to: https://github.com/smallrye/smallrye-config/edit/main/doc/modules/ROOT/pages/config/config.adoc

@radcortez
Copy link
Member

BTW, the edit link on the website is broken.

It points to: https://github.com/smallrye/smallrye-config/edit/main/doc/modules/ROOT/pages/config/config.adoc

Strange. It works for me. Which page were you looking at to edit?

I've used: https://smallrye.io/smallrye-config/Main/config/secret-keys/ and the edit links sent me to https://github.com/smallrye/smallrye-config/edit/main/documentation/src/main/docs/config/secret-keys.md

@radcortez radcortez merged commit 8797480 into smallrye:main Aug 31, 2022
@gsmet
Copy link
Contributor Author

gsmet commented Aug 31, 2022

Using Google to look for smallrye config secret keys, I ended up on https://smallrye.io/docs/smallrye-config/config/secret-keys.html .

@radcortez
Copy link
Member

Ah, that is the old docs page. It seems Antora was not smart enough to remove it. I'll need to do it manually.

@radcortez radcortez added this to the 2.12.0 milestone Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants