Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix the Sonar plugin integration" #795

Closed
wants to merge 1 commit into from

Conversation

sberyozkin
Copy link
Contributor

Reverts #778 for now as it failed the release insisting on improving the coverage, unless we can skip it for the release task only ?
Mike, Roberto, what do you think ?

@sberyozkin sberyozkin requested review from radcortez and MikeEdgar May 10, 2024 10:22
@sberyozkin sberyozkin requested a review from a team as a code owner May 10, 2024 10:22
@sberyozkin
Copy link
Contributor Author

I mean, I do support the idea of the improving the code coverage :-), but I don't have time now to go through all of the smallrye-jwt code to do it just to make a 4.5.2 release :-), hopefully Quarkus 3.11.0.CR1 will pick it up

@MikeEdgar
Copy link
Member

@sberyozkin where did you see something about the coverage failing the release? I see here [1] there's an error for unstaged changes.

[1] https://github.com/smallrye/smallrye-jwt/actions/runs/9030492730/job/24814876184

@MikeEdgar
Copy link
Member

I think this file needs to be formatted. The release auto-formats it and then git detects the file changed:
implementation/common/src/test/java/io/smallrye/jwt/util/KeyUtilsTest.java

@sberyozkin
Copy link
Contributor Author

Oh, sorry @MikeEdgar, it was the first thing I noticed, the sonar plugin failing, and did not scroll down :-). Now I recall, I did a clean build, and was wondering why was this test code got changed for me...
Sorry about the hassle, let me deal with it

@sberyozkin sberyozkin closed this May 10, 2024
@MikeEdgar
Copy link
Member

No hassle at all 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants