SNOW-2004510: Fix build warnings #1124
Merged
+14
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1124 +/- ##
==========================================
+ Coverage 86.25% 86.36% +0.11%
==========================================
Files 132 132
Lines 12679 12679
Branches 1302 1302
==========================================
+ Hits 10936 10950 +14
+ Misses 1417 1405 -12
+ Partials 326 324 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sfc-gh-knozderko
approved these changes
Mar 26, 2025
sfc-gh-fpawlowski
approved these changes
Mar 27, 2025
| @@ -109,7 +109,7 @@ public void TestReadMoreBytesThanBufferSize() | |||
| try | |||
| { | |||
| // An ArgumentException is thrown when 4 bytes is read from a buffer of size 3 | |||
| _concatStream.Read(buffer, 0, 4); | |||
| var readBytes = _concatStream.Read(buffer, 0, 4); | |||
There was a problem hiding this comment.
It is, however, if the return of the Read is not assigned to the variable, the compiler complains about it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix build warnings
Checklist
dotnet test)