This repository was archived by the owner on Jan 22, 2025. It is now read-only.
RPC instruction parser tests are missing some cases #25951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
June 13, 2022 13:13
CriesofCarrots
added
v1.10
automerge
mergify bot
pushed a commit
that referenced
this pull request
Jun 14, 2022
* Fix num-accounts typo and extend test * Add extra test cases to parse_system * Add extra test cases to parse_vote * Add extra test cases to parse_stake * Fixup parse_bpf_loader * Add extra test cases to parse_bpf_upgradeable_loader * Add extra test cases to parse_associated_token (cherry picked from commit 7b786ff)
mergify bot
added a commit
that referenced
this pull request
Jun 14, 2022
* Fix num-accounts typo and extend test * Add extra test cases to parse_system * Add extra test cases to parse_vote * Add extra test cases to parse_stake * Fixup parse_bpf_loader * Add extra test cases to parse_bpf_upgradeable_loader * Add extra test cases to parse_associated_token (cherry picked from commit 7b786ff) Co-authored-by: Tyera Eulberg <tyera@solana.com>
mergify bot
pushed a commit
that referenced
this pull request
Jun 18, 2022
* Fix num-accounts typo and extend test * Add extra test cases to parse_system * Add extra test cases to parse_vote * Add extra test cases to parse_stake * Fixup parse_bpf_loader * Add extra test cases to parse_bpf_upgradeable_loader * Add extra test cases to parse_associated_token (cherry picked from commit 7b786ff) # Conflicts: # transaction-status/src/parse_associated_token.rs # transaction-status/src/parse_bpf_loader.rs # transaction-status/src/parse_stake.rs # transaction-status/src/parse_system.rs # transaction-status/src/parse_vote.rs
CriesofCarrots
pushed a commit
that referenced
this pull request
Jun 18, 2022
* Fix num-accounts typo and extend test * Add extra test cases to parse_system * Add extra test cases to parse_vote * Add extra test cases to parse_stake * Fixup parse_bpf_loader * Add extra test cases to parse_bpf_upgradeable_loader * Add extra test cases to parse_associated_token
CriesofCarrots
pushed a commit
that referenced
this pull request
Jun 18, 2022
* Fix num-accounts typo and extend test * Add extra test cases to parse_system * Add extra test cases to parse_vote * Add extra test cases to parse_stake * Fixup parse_bpf_loader * Add extra test cases to parse_bpf_upgradeable_loader * Add extra test cases to parse_associated_token
mergify bot
added a commit
that referenced
this pull request
Jun 18, 2022
…#26057) * Make instruction-parsing tests less brittle Cribbed from #23729 to ease backports * RPC instruction parser tests are missing some cases (#25951) * Fix num-accounts typo and extend test * Add extra test cases to parse_system * Add extra test cases to parse_vote * Add extra test cases to parse_stake * Fixup parse_bpf_loader * Add extra test cases to parse_bpf_upgradeable_loader * Add extra test cases to parse_associated_token Co-authored-by: Justin Starry <justin@solana.com> Co-authored-by: Tyera Eulberg <tyera@solana.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Instruction parser tests don't verify that the instruction parsers return a happy error instead of a panic when the instruction's
accountsvector is too short to cover the indexes used.Summary of Changes
Add such test cases