Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show warning for sensitive app permissions. #262

Merged
merged 1 commit into from
Apr 23, 2024
+26 −2
Merged

show warning for sensitive app permissions. #262

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions packages/cli/src/config/PublishDetails.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ const getAndroidDetails = async (
const minSdk = new RegExp(
AaptPrefixes.sdkPrefix + AaptPrefixes.quoteRegex
).exec(stdout);
const permissions = [...stdout.matchAll(/uses-permission: name='(.*)'/g)];
const permissions = [...stdout.matchAll(/uses-permission: name='(.*)'/g)].flatMap(permission => permission[1]);
const locales = new RegExp(
AaptPrefixes.localePrefix + AaptPrefixes.quoteNonLazyRegex
).exec(stdout);
Expand All @@ -247,6 +247,30 @@ const getAndroidDetails = async (
localeArray = ["en-US"].concat(localesSrc.split("' '").slice(1));
}

if (permissions.includes("android.permission.INSTALL_PACKAGES") || permissions.includes("android.permission.DELETE_PACKAGES")) {
showMessage(
"App requests system app install/delete permission",
"Your app requests system install/delete permission which is managed by Solana dApp Store.\nThis app will be not approved for listing on Solana dApp Store.",
"error"
);
}

if (permissions.includes("android.permission.REQUEST_INSTALL_PACKAGES") || permissions.includes("android.permission.REQUEST_DELETE_PACKAGES")) {
showMessage(
"App requests install or delete permission",
"App will be subject to additional security reviews for listing on Solana dApp Store and processing time may be beyond regular review time",
"warning"
);
}

if (permissions.includes("com.solanamobile.seedvault.ACCESS_SEED_VAULT")) {
showMessage(
"App requests Seed Vault permission",
"If this is not a wallet application, your app maybe rejected from listing on Solana dApp Store.",
"warning"
);
}

if (localeArray.length >= 60) {
showMessage(
"The bundle apk claims supports for following locales",
Expand All @@ -264,7 +288,7 @@ const getAndroidDetails = async (
version_code: parseInt(versionCode?.[1] ?? "0", 10),
version: versionName?.[1] ?? "0",
cert_fingerprint: await extractCertFingerprint(aaptDir, apkPath),
permissions: permissions.flatMap(permission => permission[1]),
permissions: permissions,
locales: localeArray
};
} catch (e) {
Expand Down
Loading