Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RestFul API #542

Merged
merged 1 commit into from
Jul 12, 2020
Merged

Fix RestFul API #542

merged 1 commit into from
Jul 12, 2020

Conversation

wbloszyk
Copy link
Member

@wbloszyk wbloszyk commented Jul 4, 2020 •
edited
Loading

Subject

I am targeting this branch, because this change respect BC.

Part of sonata-project/dev-kit#778

Changelog

### Added
- Added public alias `Sonata\ClassificationBundle\Controller\Api\CategoryController` for `sonata.classification.controller.api.category` service
- Added public alias `Sonata\ClassificationBundle\Controller\Api\CollectionController` for `sonata.classification.controller.api.collection` service
- Added public alias `Sonata\ClassificationBundle\Controller\Api\TagController` for `sonata.classification.controller.api.tag` service
- Added public alias `Sonata\ClassificationBundle\Controller\Api\ContextController` for `sonata.classification.controller.api.context` service
### Fixed
- fix RestFul API - `Class could not be determined for Controller identified` Error

@wbloszyk wbloszyk mentioned this pull request Jul 4, 2020
Closed
43 tasks
jordisala1991
jordisala1991 reviewed Jul 5, 2020
View reviewed changes
src/Resources/config/routing/api.xml
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?>
<routes xmlns="http://friendsofsymfony.github.com/schema/rest" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://friendsofsymfony.github.com/schema/rest https://raw.githubusercontent.com/FriendsOfSymfony/FOSRestBundle/master/Resources/config/schema/routing/rest_routing-1.0.xsd">
Copy link
Member

@jordisala1991 jordisala1991 Jul 5, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file in the @phansys pr was handled different

Copy link
Member Author

@wbloszyk wbloszyk Jul 5, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but i dont add support for fos/rest v3

@phansys phansys added the patch label Jul 5, 2020
phansys
phansys requested changes Jul 5, 2020
View reviewed changes
Copy link
Member

@phansys phansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests? Maybe these can be used as base.

@wbloszyk
Copy link
Member Author

wbloszyk commented Jul 5, 2020

@phansys Tomorrow I will open fix restful api PRs for all bundles where is it require. Additional I will open PR in sandbox for check it and fix on sandbox.

IMHO Functional tests should be add for all bunsles. Some things like router config should be tested.

BTW
I think about move fixtures from sandbox to seperate bundle. This will allow install demo data for each bundles and allow test it in Functional tests. I will open dev-kit issue for it.

@wbloszyk
Copy link
Member Author

@phansys Can we merge it without tests? I think we should first decide what to do with RESTful.
sonata-project/dev-kit#778 (comment)

@phansys
Copy link
Member

phansys commented Jul 12, 2020

@phansys Can we merge it without tests? I think we should first decide what to do with RESTful.
sonata-project/dev-kit#778 (comment)

No problem.

@jordisala1991 jordisala1991 merged commit 2a4f0f3 into sonata-project:3.x Jul 12, 2020
@jordisala1991
Copy link
Member

Thank you @wbloszyk

@wbloszyk wbloszyk deleted the fix_restful_api branch July 12, 2020 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordisala1991 jordisala1991 jordisala1991 left review comments

@phansys phansys phansys approved these changes

Assignees
No one assigned
Labels
Needs: Tests patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wbloszyk @phansys @jordisala1991