Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.

Update conflict constraint for "nelmio/api-doc-bundle" in order to allow version 3 #635

Closed
wants to merge 1 commit into from
Closed

Update conflict constraint for "nelmio/api-doc-bundle" in order to allow version 3 #635

wants to merge 1 commit into from

Conversation

wbloszyk
Copy link
Member

@wbloszyk wbloszyk commented Sep 2, 2020 •
edited
Loading

Subject

Update conflict constraint for "nelmio/api-doc-bundle" in order to allow version 3.

I am targeting this branch, because these changes almost respect BC (with one, very little BC-break potential).

Changelog

### Added
- support for `nelmio/api-doc-bundle` >= 3.6
### Changed
- Updated docs in order to expose how to configure custom serialization paths under jms_serializer configuration node (jms_serializer.metadata.directories).

@wbloszyk wbloszyk mentioned this pull request Sep 2, 2020
Closed
43 tasks
@wbloszyk wbloszyk marked this pull request as ready for review September 15, 2020 14:57
@wbloszyk wbloszyk requested review from phansys and a team September 15, 2020 14:57
@wbloszyk wbloszyk requested review from phansys and a team September 15, 2020 19:25
phansys
phansys suggested changes Sep 15, 2020
View reviewed changes
@wbloszyk wbloszyk force-pushed the nelmio_3 branch 2 times, most recently from fefdf45 to b9c87d3 Compare September 15, 2020 20:10
@wbloszyk wbloszyk requested a review from phansys September 15, 2020 20:10
phansys
phansys suggested changes Sep 15, 2020
View reviewed changes
phansys
phansys previously approved these changes Sep 15, 2020
View reviewed changes
@wbloszyk wbloszyk requested a review from phansys September 15, 2020 20:34
phansys
phansys previously approved these changes Sep 15, 2020
View reviewed changes
@wbloszyk wbloszyk requested review from phansys and a team September 15, 2020 22:13
phansys
phansys suggested changes Sep 15, 2020
View reviewed changes
phansys
phansys suggested changes Sep 15, 2020
View reviewed changes
@wbloszyk wbloszyk force-pushed the nelmio_3 branch 2 times, most recently from a424f5b to c8ffec6 Compare September 16, 2020 07:10
@wbloszyk wbloszyk requested a review from phansys September 16, 2020 07:10
phansys
phansys previously approved these changes Sep 17, 2020
View reviewed changes
@OskarStark
Copy link
Member

@wbloszyk can we close #604 ?

@wbloszyk
Copy link
Member Author

@wbloszyk can we close #604 ?

Closed. I should find time to end it in this week.

@wbloszyk wbloszyk force-pushed the nelmio_3 branch 2 times, most recently from ae2c09f to d4057bc Compare September 22, 2020 17:24
@wbloszyk wbloszyk requested review from phansys and a team September 22, 2020 18:15
@wbloszyk wbloszyk force-pushed the nelmio_3 branch 4 times, most recently from d42f919 to cd94435 Compare September 25, 2020 13:18
@SonataCI
Copy link
Collaborator

Could you please rebase your PR and fix merge conflicts?

@wbloszyk @phansys
Update conflict constraint for "nelmio/api-doc-bundle" in order to al…
5e29f6f 
…low version 3

Thanks for your help

Co-authored-by: Javier Spagnoletti <phansys@gmail.com>
@VincentLanglet
Copy link
Member

What's the status of this PR ? Btw, tests are failing

@VincentLanglet VincentLanglet marked this pull request as draft June 13, 2021 16:07
@jordisala1991
Copy link
Member

Abandoned package.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@phansys phansys Awaiting requested review from phansys

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wbloszyk @OskarStark @SonataCI @VincentLanglet @jordisala1991 @phansys