This repository was archived by the owner on Jul 28, 2022. It is now read-only.
Use XML for ReST API routing #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 tasks
wbloszyk
force-pushed
the
xml_rest_routing
branch
from
8ef6d04 to
2db7432
Compare
phansys
suggested changes
Jul 31, 2020
phansys
previously approved these changes
Jul 31, 2020
|
I think this should not be considered pedantic since it removes a requirement for the api with sensio framework extra bundle |
Removing an optional requirement is pedantic IMO, but maybe I'm missing something. |
wbloszyk
force-pushed
the
xml_rest_routing
branch
from
37c51ed to
bca0c87
Compare
|
RTM |
phansys
suggested changes
Jul 31, 2020
Update tests/App/config/config.yml Co-authored-by: Javier Spagnoletti <phansys@gmail.com> Update tests/App/config/config.yml Co-authored-by: Javier Spagnoletti <phansys@gmail.com> Update tests/App/config/config.yml Co-authored-by: Javier Spagnoletti <phansys@gmail.com> Update tests/App/config/config.yml Co-authored-by: Javier Spagnoletti <phansys@gmail.com>
wbloszyk
force-pushed
the
xml_rest_routing
branch
from
8059055 to
dc4b1f9
Compare
phansys
approved these changes
Aug 3, 2020
jordisala1991
approved these changes
Aug 3, 2020
|
Thank you @wbloszyk |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Use XML for ReST API routing.
I am targeting this branch, because this change respects BC.
Related to sonata-project/SonataMediaBundle#1767 (comment).
Changelog