Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix database schema for mssql" #1165

Merged
merged 1 commit into from
Jun 21, 2020

Conversation

wbloszyk
Copy link
Member

This reverts commit 331446b

Subject

I am targetting this branch, because this is a bugfix.

Closes #1163.

Changelog

### Removed
- Remove support for mssql database
### Fixed
- Fix mysql database schema

Copy link
Member

@jordisala1991 jordisala1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the changelog should be handled different, wdyt @greg0ire ?

@VincentLanglet
Copy link
Member

For this one, a release was made with the changelog

Fixed
fixed sql to work with mssql

So we need to add in the changelog of the release that we fix the issue AND we remove the support added.
For other PRs, since no release was made, we just have to no add any changelog for both the fix and the revert.

@wbloszyk
Copy link
Member Author

ClassificationBundle and PageBundle should have changelog.

@jordisala1991 jordisala1991 merged commit 0f77d29 into sonata-project:3.x Jun 21, 2020
@jordisala1991
Copy link
Member

Thank you @wbloszyk

@wbloszyk
Copy link
Member Author

@greg0ire Can you release this.

@wbloszyk wbloszyk deleted the revert_mssql branch June 22, 2020 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to delete blocks: RESTRICT on parent_id foreign key. What (offending commit inside)?
4 participants