Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for CacheBundle 3 and PHP 8 #1341

Merged
merged 3 commits into from
Aug 22, 2021
Merged

Add support for CacheBundle 3 and PHP 8 #1341

merged 3 commits into from
Aug 22, 2021

Conversation

VincentLanglet
Copy link
Member

Subject

Finishing #1304 and #1274.

I am targeting this branch, because we decided it was acceptable on this branch.
#1304 (comment)

Changelog

### Added
- Support for `SonataCacheBundle` v3.
- Support for PHP 8.
- Some return type hint to `BlockEsiCache`, `BlockJsCache` and `BlockSsiCache`.

### Changed
- `BlockEsiCache::__construct` signature
- `BlockSsiCache::__construct` signature

### Removed
- Support for `SonataCacheBundle` v2.
- Support for `SonataCache` v1.

@VincentLanglet VincentLanglet requested review from a team and jordisala1991 August 21, 2021 09:29
@VincentLanglet VincentLanglet mentioned this pull request Aug 21, 2021
Merged
@VincentLanglet
Copy link
Member Author

Dev-kit PR: sonata-project/dev-kit#1636

core23
core23 previously approved these changes Aug 21, 2021
View reviewed changes
@VincentLanglet VincentLanglet requested review from a team and phansys August 21, 2021 10:26
phansys
phansys requested changes Aug 22, 2021
View reviewed changes
@VincentLanglet
Copy link
Member Author

Done @phansys

@VincentLanglet VincentLanglet merged commit 120a8bf into sonata-project:3.x Aug 22, 2021
@VincentLanglet VincentLanglet deleted the cache3 branch August 22, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phansys phansys phansys approved these changes

@core23 core23 core23 left review comments

@jordisala1991 jordisala1991 Awaiting requested review from jordisala1991

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VincentLanglet @phansys @core23