Closing API

[core23]

Subject

I am targeting this branch, because this is BC.

Changelog

### Added
- Add `SnapshotInterface::getId()` method

### Changed
- Mark all classes as final

[VincentLanglet]

If we need this method, we should add it to the interface.

[core23]

Not possible on the stable branch...

[VincentLanglet]

At least @method should be added https://github.com/sonata-project/SonataPageBundle/blob/3.x/src/Model/SnapshotInterface.php#L28
And a next major can be added in the test to update the code in the test.

But in this special case, I'm not sure we can consider that adding getId to the interface is a BC-break.
It's called here: https://github.com/sonata-project/SonataPageBundle/blob/3.x/src/Entity/SnapshotManager.php#L91, so the method must be implemented anyway.

[core23]

done

[VincentLanglet]

the phpstan ignore is not needed anymore i think

[core23]

Ping @sonata-project/contributors

[VincentLanglet]

Can you take a look @jordisala1991 ?

[franmomu]

Should this be int? or mixed?

Based on PageInterface

SonataPageBundle/src/Model/PageInterface.php

Lines 27 to 32 in d102ce8

	/**
	* Returns the id.
	*
	* @return mixed
	*/
	public function getId();

(I don't know if TargetId should be mixed as well)

[core23]

The parentId is a int type at the moment:

SonataPageBundle/src/Model/SnapshotInterface.php

Line 26 in fed26c0

* @method void setParentId(?int $parentId)

If we change this, we should change it everywhere.

[VincentLanglet]

Thanks