Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove twig form themes config #1702

Merged
merged 3 commits into from
Jul 11, 2023
Merged

Remove twig form themes config #1702

merged 3 commits into from
Jul 11, 2023

Conversation

Hanmac
Copy link
Contributor

@Hanmac Hanmac commented Jul 9, 2023

Subject

I am targeting this branch, because its BC.

Closes #1699.

Changelog

### Removed
- Removed twig form themes from SonataPageExtension

@Hanmac
Copy link
Contributor Author

Hanmac commented Jul 9, 2023

hm i need to check what is wrong with the tests, normally PageBundle should have defined the values

@Hanmac
Copy link
Contributor Author

Hanmac commented Jul 11, 2023

as for more tests, I'm going to add more tests soon to form-extensions to check that twig theme definitions

@VincentLanglet
Copy link
Member

as for more tests, I'm going to add more tests soon to form-extensions to check that twig theme definitions

You mean in this Pr or another ?

@Hanmac
Copy link
Contributor Author

Hanmac commented Jul 11, 2023

as for more tests, I'm going to add more tests soon to form-extensions to check that twig theme definitions

You mean in this Pr or another ?

different project

i noticed that there are some Tests missing in the form-extensions project
(like using MockObject for Twig Extension to see if the config gets extended)
and i would add the test case later there

as for the test in this project, i only found this sonata-project/SonataUserBundle#924 and sonata-project/SonataUserBundle#925
when searching twig.form.resources but i don't know how to fix the test for the page bundle so i removed it

similar tests like in sonata-project/SonataUserBundle#925 will be later added into form-extensions

@VincentLanglet VincentLanglet merged commit 988ad5c into sonata-project:4.x Jul 11, 2023
@VincentLanglet
Copy link
Member

Thanks

@Hanmac Hanmac deleted the removeTwigTemplate branch July 11, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Twig form_themes
3 participants