Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove oppressive words from code #1191

Closed
core23 opened this issue Jul 6, 2020 · 4 comments · Fixed by #1205
Closed

Remove oppressive words from code #1191

core23 opened this issue Jul 6, 2020 · 4 comments · Fixed by #1205
Labels
Easy Pick feature

Comments

@core23
Copy link
Member

core23 commented Jul 6, 2020

Feature Request

We should avoid terms like blacklist, *whitliste, master, slave, ... and use more tech-related words like blocklist, prmary, secondary,...

In this repo, we use the term whitelist which could be replaced with allowlist:
https://github.com/sonata-project/SonataUserBundle/blob/4.x/src/GoogleAuthenticator/Helper.php#L42
@davidromani
Copy link
Contributor

Hello @core23

I'm interested in to solve it if you are agree.

@greg0ire
Copy link
Contributor

greg0ire commented Aug 8, 2020 •
edited
Loading

@davidromani knock yourself out!

The offending property is private, so in this case a simple refactor will do the trick:

SonataUserBundle/src/GoogleAuthenticator/Helper.php

Line 42 in 782cdcd

private $ipWhiteList;

I would have suggested 2FABypassingIps, but a property cannot start with a 2 so… trustedIps?

@davidromani
Copy link
Contributor

Maybe $trustedIpList is more convenient, what do you think @greg0ire?

@davidromani davidromani mentioned this issue Aug 8, 2020
Merged
3 tasks
@greg0ire
Copy link
Contributor

greg0ire commented Aug 8, 2020

I agree, it's great!

davidromani added a commit to davidromani/SonataUserBundle that referenced this issue Aug 20, 2020
@davidromani
fix issue sonata-project#1191
90f76c7
davidromani added a commit to davidromani/SonataUserBundle that referenced this issue Aug 20, 2020
@davidromani
fix issue sonata-project#1191
ccf5d62
davidromani added a commit to davidromani/SonataUserBundle that referenced this issue Aug 20, 2020
@davidromani
fix issue sonata-project#1191
634faa2
davidromani added a commit to davidromani/SonataUserBundle that referenced this issue Aug 21, 2020
@davidromani
Remove oppressive words from code.
4e9613e 
"ip_white_list" from "google_authenticator" configuration key has been replaced by "trusted_ip_list" key.
For now, both configuration keys are valid, but only one can be used at same time.
"ip_white_list" has been marked as deprecated and will be removed in next major release to keep BC in 4.x branch.
Fixes sonata-project#1191
franmomu pushed a commit that referenced this issue Aug 30, 2020
@davidromani @franmomu
Remove oppressive words from code.
b8eca6d 
"ip_white_list" from "google_authenticator" configuration key has been replaced by "trusted_ip_list" key.
For now, both configuration keys are valid, but only one can be used at same time.
"ip_white_list" has been marked as deprecated and will be removed in next major release to keep BC in 4.x branch.
Fixes #1191
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Easy Pick feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove oppressive words from code davidromani/SonataUserBundle
3 participants
@greg0ire @davidromani @core23