-
-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: display errors in reset template #1180
Fix: display errors in reset template #1180
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
form_errors
is after form_widget
as in the base bootstrap form template.
Also we don't need to add the form_errors
call on the other field, since errors for repeated fields are always mapped to the first field.
@@ -48,6 +48,7 @@ file that was distributed with this source code. | |||
'class': 'form-control', | |||
'placeholder': 'form.new_password'|trans({}, 'FOSUserBundle') | |||
}}) }} | |||
{{ form_errors(form.plainPassword.first) }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add this for the second as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is not need, check RepeatedTypeValidatorExtension.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It depends, what other validation was added by the developer.
Currently the reset form do not display errors message. I have added a line after the form widget for display errors messages. The best would be to replace form widget with a form row to display bootstrap template.
Thank you @clementlefrancois |
Subject
Currently the reset form do not display errors message.
I have added a line after the form widget for display errors messages.
The best would be to replace form widget with a form row to display bootstrap template.
I am targeting this branch, because this is a bug fix.
Closes #1179
Changelog