Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow symfony/options-resolver to use version ^5.1 #1210

Merged
merged 1 commit into from
Aug 29, 2020

Conversation

phansys
Copy link
Member

@phansys phansys commented Aug 20, 2020

Subject

Allow symfony/options-resolver to use version ^5.1, since this major version doesn't have breaking changes. See:

I am targeting this branch, because this change respects BC.

Depends on sonata-project/SonataAdminBundle#6299, sonata-project/SonataDoctrineORMAdminBundle#1091, sonata-project/SonataBlockBundle#730.
.

Changelog

### Added
- Added support for symfony/options-resolver:^5.1.

@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2020

Codecov Report

Merging #1210 into 4.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                4.x    #1210   +/-   ##
=========================================
  Coverage     69.51%   69.51%           
  Complexity      455      455           
=========================================
  Files            46       46           
  Lines          1404     1404           
=========================================
  Hits            976      976           
  Misses          428      428           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ede44b...205d283. Read the comment docs.

@phansys phansys changed the title Allow symfony/options-resolver to use version ^5.0 Allow symfony/options-resolver to use version ^5.1 Aug 29, 2020
@jordisala1991 jordisala1991 changed the title Allow symfony/options-resolver to use version ^5.0 Allow symfony/options-resolver to use version ^5.1 Aug 29, 2020
@phansys phansys marked this pull request as ready for review August 29, 2020 11:39
@phansys phansys requested a review from a team August 29, 2020 11:40
@greg0ire greg0ire merged commit e5de41b into sonata-project:4.x Aug 29, 2020
@greg0ire
Copy link
Contributor

Thanks @phansys !

@phansys phansys deleted the symfony_deps branch August 29, 2020 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants