-
-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed config line causing issue on google authenticator #1212
Removed config line causing issue on google authenticator #1212
Conversation
This fixes the following issue: Stop sonata-project/google-authenticator throwing this exception: Exception thrown when handling an exception (ErrorException: Warning: get_class() expects parameter 1 to be object, null given at /sonata-project/user-bundle/src/GoogleAuthenticator/RequestListener.php line 77
@jordisala1991 this is what we talked about on the sonata slack channel |
There are 2 ways to fix the issue, the first one is to remove that line, IMO the cleanest one. The other way is to allow null on the construct (now it is forbidden with an Exception here: https://github.com/sonata-project/SonataUserBundle/blob/4.x/src/GoogleAuthenticator/RequestListener.php#L72 I think what happened is that we removed the |
Seems like your github account and your git config is not the same, that causes your commit to not show your avatar. Can you link your email to your git config? |
Done. Next commit will show the correct avatar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, the changelog should use the "Fixed" section instead of "Changed", since this is a patch.
True, it's done 👍 |
Forcing the CI pipeline to be triggered in order to allow the new required steps to be executed. |
Thanks @Jean-ita |
Subject
This fixes the following error:
Stop sonata-project/google-authenticator throwing this exception: Exception thrown when handling an exception (ErrorException: Warning: get_class() expects parameter 1 to be object, null given at /sonata-project/user-bundle/src/GoogleAuthenticator/RequestListener.php line 77
Changelog