Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sonata-project/datagrid-bundle to version ^3.0 #1230

Merged
merged 1 commit into from
Sep 25, 2020

Conversation

wbloszyk
Copy link
Member

Subject

I am targeting this branch, because we should bump in this branch. It is potential BC-break.

Changelog

### Added
- support for sonata-project/datagrid-bundle to version ^3.0
### Removed
- support for sonata-project/datagrid-bundle to version < 3.0

VincentLanglet
VincentLanglet previously approved these changes Sep 23, 2020
@VincentLanglet
Copy link
Member

Test are failing

@wbloszyk
Copy link
Member Author

@VincentLanglet Test are failing becouse API. The will be fix in #1225.

@wbloszyk wbloszyk force-pushed the bump_datagrid branch 2 times, most recently from 019ac12 to 011fd62 Compare September 23, 2020 14:46
@wbloszyk wbloszyk requested review from phansys and a team September 23, 2020 14:48
phansys
phansys previously approved these changes Sep 23, 2020
@wbloszyk wbloszyk requested a review from a team September 24, 2020 12:23
VincentLanglet
VincentLanglet previously approved these changes Sep 24, 2020
@wbloszyk wbloszyk requested a review from a team September 24, 2020 14:26
@wbloszyk
Copy link
Member Author

@phansys Can you re-check it?

phansys
phansys previously approved these changes Sep 24, 2020
@wbloszyk wbloszyk dismissed stale reviews from phansys and VincentLanglet via ab78fca September 24, 2020 22:50
Update UPGRADE-4.x.md

Co-authored-by: Javier Spagnoletti <phansys@gmail.com>

Update UPGRADE-4.x.md

Co-authored-by: Javier Spagnoletti <phansys@gmail.com>

Update tests/Controller/Api/UserControllerTest.php

Co-authored-by: Javier Spagnoletti <phansys@gmail.com>

Update tests/Controller/Api/GroupControllerTest.php

Co-authored-by: Javier Spagnoletti <phansys@gmail.com>

Update tests/Controller/Api/UserControllerTest.php

Co-authored-by: Javier Spagnoletti <phansys@gmail.com>

Update UPGRADE-4.x.md

Co-authored-by: Javier Spagnoletti <phansys@gmail.com>

Update UPGRADE-4.x.md

Co-authored-by: Javier Spagnoletti <phansys@gmail.com>

Update UPGRADE-4.x.md

Co-authored-by: Javier Spagnoletti <phansys@gmail.com>

Update UPGRADE-4.x.md

Co-authored-by: Javier Spagnoletti <phansys@gmail.com>

Update UPGRADE-4.x.md

Co-authored-by: Javier Spagnoletti <phansys@gmail.com>
@VincentLanglet VincentLanglet merged commit 05bff41 into sonata-project:4.x Sep 25, 2020
@VincentLanglet
Copy link
Member

Thanks

@wbloszyk wbloszyk deleted the bump_datagrid branch September 25, 2020 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants