Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC]Drop "friendsofsymfony/user-bundle" #1253

Closed
wants to merge 37 commits into from

Conversation

wbloszyk
Copy link
Member

@wbloszyk wbloszyk commented Oct 12, 2020

Subject

I create this PR becouse current branch is working. Some of things is still must be move, rewrite or refactor.

I am targeting this branch, because this change are not respect BC.

Closes #1112.

Changelog

### Added
- Added some `Class::newMethod()` to do great stuff.

### Changed

### Deprecated

### Removed

### Fixed

### Security

Current status

  • database: working
  • admin panel: working
  • login system: working
  • change password: working
  • send email: working
  • resetting: working

Things to move

  • Command
  • Controller - do not needed in admin panel
  • Events - only this require by admin
  • Mailer
  • Model
  • Resources
    • doc
    • translations
      • bundle translations
      • validators
    • views
  • Security
  • Util
  • Validator

To do

  • Move translations
  • Move events
  • Update the changelog
  • Update the tests
  • Update the documentation
  • Add an upgrade note

@SonataCI
Copy link
Collaborator

Could you please rebase your PR and fix merge conflicts?

@SonataCI
Copy link
Collaborator

Could you please rebase your PR and fix merge conflicts?

@jordisala1991
Copy link
Member

Food for thoughts or things to discuss about:

  • Do we need all the implementations on FosUser to have a user system?
  • Do we want to use Swiftmailer?
  • Maybe we should use Symfony guards instead of the implementation of Fos

@wbloszyk wbloszyk linked an issue Oct 14, 2020 that may be closed by this pull request
@wbloszyk wbloszyk changed the title Drop "friendsofsymfony/user-bundle" [POC]Drop "friendsofsymfony/user-bundle" Oct 15, 2020
@wbloszyk wbloszyk requested a review from a team February 8, 2021 14:08
@wbloszyk wbloszyk closed this Feb 8, 2021
@wbloszyk wbloszyk reopened this Feb 8, 2021
@VincentLanglet
Copy link
Member

A rebase is required

@wbloszyk wbloszyk closed this Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove FOSUserBundle inheritance
5 participants