Stop extending AbstractAdmin::getExportFields()
#1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
approved these changes
Oct 13, 2020
There was a problem hiding this comment.
It looks like this also will have the side effect of making extensions added to the UserAdmin able to change export fields. Link for the lazy: https://github.com/sonata-project/SonataAdminBundle/blob/6d32a6fc4e285dfe6ae32af6d2428d122e33e9c9/src/Admin/AbstractAdmin.php#L665-L676
jordisala1991
approved these changes
Oct 13, 2020
|
Thank you @phansys |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Stop extending
AbstractAdmin::getExportFields(), since this method is marked as final.I am targeting this branch, because this change respects BC.
Changelog