Remove groups feature #1468
Merged
Remove groups feature #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordisala1991
force-pushed
the
feature/remove-groups
branch
from
51ef9cd to
6ac2133
Compare
VincentLanglet
requested changes
Jan 3, 2022
src/Admin/Model/UserAdmin.php
Outdated
| ->with('Keys', ['class' => 'col-md-4'])->end() | ||
| ->with('Roles', ['class' => 'col-md-12'])->end() | ||
| ->with('Roles', ['class' => 'col-md-16'])->end() |
There was a problem hiding this comment.
This is wrong. 12 is the max. You should instead change the col-md-4 to col-md-6 for status and keys.
There was a problem hiding this comment.
Tried to fix it on my last commit. Should be better now.
VincentLanglet
approved these changes
Jan 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because this breaks BC.
To me it does not need extra deprecations on 4.x since FOSUser already deprecated the feature and we are relying on it.
Changelog