Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve NEXT_MAJOR comments #1479

Merged

Conversation

jordisala1991
Copy link
Member

@jordisala1991 jordisala1991 commented Jan 9, 2022

Subject

I am targeting this branch, because this is for next major.

Changelog

### Added
- Added `EditableRolesBuilderInterface`.

### Changed
- Changed `__construct()` of `EditableRolesBuilder` to provide `TranslatorInterface`

@jordisala1991 jordisala1991 requested review from VincentLanglet and a team January 9, 2022 10:16
@VincentLanglet
Copy link
Member

Tests need to be updated

  • Some private methods were tested
  • Some mock were made on final classes

@VincentLanglet
Copy link
Member

For the label, I think the major label require to have a Changelog.
So as a hack, we have to use the pedantic label in order to generate the release changelog with the dev kit command.

@jordisala1991 jordisala1991 force-pushed the improvement/final-private branch 2 times, most recently from c61e3ca to b6808c7 Compare January 9, 2022 15:13
@jordisala1991
Copy link
Member Author

For the label, I think the major label require to have a Changelog. So as a hack, we have to use the pedantic label in order to generate the release changelog with the dev kit command.

I have added the changelog, had to introduce a new interface.

I didn't touch a metod that should be private because I will be fixing that on another PR. (I noted it on the 5.0 roadmap issue)

@jordisala1991 jordisala1991 force-pushed the improvement/final-private branch from b6808c7 to 01faf22 Compare January 9, 2022 16:28
@jordisala1991 jordisala1991 force-pushed the improvement/final-private branch from d89b95c to d99f48e Compare January 9, 2022 16:44
VincentLanglet
VincentLanglet previously approved these changes Jan 9, 2022
@jordisala1991 jordisala1991 merged commit d52bb88 into sonata-project:5.x Jan 9, 2022
@jordisala1991 jordisala1991 deleted the improvement/final-private branch January 9, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants