Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Font Awesome 5 icons #1485

Merged
merged 1 commit into from
Jan 30, 2022
Merged

Use Font Awesome 5 icons #1485

merged 1 commit into from
Jan 30, 2022

Conversation

jordisala1991
Copy link
Member

Subject

I am targeting this branch, because this is for Sonata 4.

Part of #1465

Changelog

### Fixed
- Fixed icons usage for Font Awesome 5.

@jordisala1991 jordisala1991 requested review from VincentLanglet and a team January 30, 2022 15:59
VincentLanglet
VincentLanglet approved these changes Jan 30, 2022
View reviewed changes
Copy link
Member

@VincentLanglet VincentLanglet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phpstan need to be fixed

@jordisala1991
Copy link
Member Author

Phpstan need to be fixed

#1484

It is fixed here.

@jordisala1991 jordisala1991 reopened this Jan 30, 2022
@jordisala1991 jordisala1991 merged commit da3d45c into sonata-project:5.x Jan 30, 2022
@jordisala1991 jordisala1991 deleted the hotfix/use-font-awesome branch January 30, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VincentLanglet VincentLanglet VincentLanglet approved these changes

Assignees
No one assigned
Labels
major
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jordisala1991 @VincentLanglet