Exclude ROLE_DEFAULT from RoleMatrixType #1540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jordisala1991 is this good for a fix or should i extend the test cases more for the excluded option? or if for example i set the excluded option to only |
jordisala1991
previously approved these changes
Jun 25, 2022
VincentLanglet
requested changes
Jun 25, 2022
Hanmac
force-pushed
the
excludeRoleDefault
branch
from
951cd7d to
4550e58
Compare
is that clear or should i add more config option? like defining it an Configuration option? |
|
For each option you add to an option resolver is a good practice to provide its allowed types, in this case it should be 'string[]'. Can you add that option? |
VincentLanglet
previously approved these changes
Jun 28, 2022
|
Your Opinion if that option should be configuable over the Config yml too? |
VincentLanglet
approved these changes
Jun 28, 2022
I don't think this is needed so far. Less config option is better if not needed. |
|
Is it ok for you @jordisala1991 ? |
jordisala1991
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because it should be BC.
Per default only
UserInterface::ROLE_DEFAULTakaROLE_USERis excluded, but users can still use it.If this Component would be moved outside of UserBundle that might be changed.
Closes #1535.
Changelog