fix: add UniqueEntity constraint to email field.

[m-ar-c]

Subject

This PR add UniqueEntity constraint to email field in validation.xml.

Why :
The email property is defined as unique in the DB, so we need to
constraint the field to unique in the form in order to prevent a
UniqueConstraintViolationException exception.

I am targeting this branch, because it is BC.

Changelog

### Fixed
- Add UniqueEntity constraint to email field in order to prevent UniqueConstraintViolationException exception.

[Hanmac]

i see this a bit critical, for one of my projects i need to have users with different ids but with same email

it is easy to overwrite the doctrine setting for uniq column, but it isn't possible to remove unique entry validation.
that only works if you can somehow set a different valdiation group (which i don't know if it is possible with sonata user bundle)

[VincentLanglet]

i see this a bit critical, for one of my projects i need to have users with different ids but with same email

it is easy to overwrite the doctrine setting for uniq column, but it isn't possible to remove unique entry validation. that only works if you can somehow set a different valdiation group (which i don't know if it is possible with sonata user bundle)

As long as we define the property as unique in database, we should be consistent and add an annotation IMHO.

How do you override the unique definition ? It could be interesting to see if you cannot override the annotation too.
Because it's kinda the job of the one overriding the unique=true to remove the annotation and not the bundle to not provide an annotation in order to allow people to override. (cc @jordisala1991 if you know how)

[Hanmac]

For ORM, @AttributeOverride

• https://symfony.com/doc/current/bundles/override.html#entities-entity-mapping
• https://www.doctrine-project.org/projects/doctrine-orm/en/latest/reference/inheritance-mapping.html#attribute-override

for Validator:

• https://symfony.com/doc/current/bundles/override.html#validation-metadata

To overcome this, the 3rd party bundle needs to have configuration for validation groups. For instance, the FOSUserBundle has this configuration. To create your own validation, add the constraints to a new validation group

the other contraints have groups like "Registration", the new one has not.

Also it should probably be better configured where the Validation Groups are used.

[VincentLanglet]

Indeed since there is validation group everywhere we should use it too.

Does adding

                <option name="groups">
                    <value>Registration</value>
                    <value>Profile</value>
                </option>

would solve your issue @Hanmac ?

[Hanmac]

Indeed since there is validation group everywhere we should use it too.

Does adding

                <option name="groups">
                    <value>Registration</value>
                    <value>Profile</value>
                </option>

would solve your issue @Hanmac ?

i would need to debug it, but i could work with that i think

[VincentLanglet]

If you have time to try in order to confirm it, it would be great. This would avoid us to block you ^^

[m-ar-c]

So, to add validation group, I just need to remove the line (24) <constraint name="Email"/> I added, since there already was a

            <constraint name="Email">
                <option name="groups">
                    <value>Registration</value>
                    <value>Profile</value>
                </option>
            </constraint>

block in the code. Am I right ? (I tested of course, unique validation on email still works with the line removed).

[jordisala1991]

This line could be removed.

[VincentLanglet]

Suggested change

	<option name="groups">
	<option name="groups">

I'm not sure but the indent seems weird

[jordisala1991]

Thanks @m-ar-c

@Hanmac You can override the validation groups for the admin, take a look at the model user admin.