This repository was archived by the owner on Jul 22, 2022. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 139
Allow "friendsofsymfony/rest-bundle:^3.0" #688
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 tasks
6d84d43
to
6004461
Compare
phansys
reviewed
Aug 1, 2020
6004461
to
a133c43
Compare
a133c43
to
111113d
Compare
phansys
previously approved these changes
Aug 18, 2020
111113d
to
d8ed128
Compare
Codecov Report
@@ Coverage Diff @@
## 3.x #688 +/- ##
=========================================
Coverage 45.33% 45.33%
Complexity 2500 2500
=========================================
Files 191 191
Lines 8127 8127
=========================================
Hits 3684 3684
Misses 4443 4443
Continue to review full report at Codecov.
|
@sonata-project/contributors Can you check it? |
phansys
approved these changes
Sep 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be nice to have some tests covering these routes.
I will add it at the end, after add support for nelmio/api-doc-bundle v3 |
@OskarStark Can you look at DOCtor-RTS? You make somethig simmilar (to this), where nelmio/api-doc work with |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Allow "friendsofsymfony/rest-bundle:^3.0".
I am targeting this branch, because these changes respect BC.
Changelog