feat: version checking for core components #1756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3Hren
added
T: feature
3Hren
requested review from
antmat,
zavgorodnii,
nikonov1101 and
a team
as code owners
nikonov1101
reviewed
Nov 27, 2018
insonmnia/version/version.go
Outdated
| return time.Add(m.expireDuration).Before(m.clock()) | ||
| } | ||
|
|
||
| // how to use it: |
There was a problem hiding this comment.
Probably will be better to move usage info into the top of the file?
There was a problem hiding this comment.
Oh, it's just an ancient artifact. I'll drop it.
Currently we often have a situation when our clients (both suppliers and customers) don't know whether a new version of the platform has been released. To avoid this we've done a simple console notification as a warning about whether it's time to update.
3Hren
force-pushed
the
feat/xx/version-checking
branch
from
a8606b8 to
510e8d4
Compare
nikonov1101
approved these changes
Nov 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we often have a situation when our clients (both suppliers and customers) don't know whether a new version of the platform has been released. To avoid this we've done a simple console notification as a warning about whether it's time to update.