Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests to store funcs + add source-based sorting + coordinator URL validation #228

Merged
merged 10 commits into from
Feb 9, 2025

Conversation

sonroyaalmerol
Copy link
Owner

@sonroyaalmerol sonroyaalmerol commented Feb 9, 2025

Context

  • Majority of the PR is to add automated tests on most of the store functions.
  • Also adds source as an option for SORTING_KEY (Disable sorting altogether? #217)
  • This also adds an additional step in the stream coordinator which validates the requested URL and uses the title of the stream instead as its identifier. (related to Channels Not Playing Right #227)

Choices

Test instructions

Checklist before requesting a review

  • I have performed a self-review of my code
  • I've added documentation about this change to the README.
  • I've not introduced breaking changes.

@sonroyaalmerol sonroyaalmerol changed the title add tests to store fns + add source-based sorting + coordinator URL validation add tests to store funcs + add source-based sorting + coordinator URL validation Feb 9, 2025
@sonroyaalmerol sonroyaalmerol marked this pull request as ready for review February 9, 2025 00:55
Copy link

github-actions bot commented Feb 9, 2025

The Docker image for this pull request has been built and pushed to GHCR.

Image URL: ghcr.io/sonroyaalmerol/m3u-stream-merger-proxy:pr-228

@sonroyaalmerol sonroyaalmerol merged commit 37996e8 into main Feb 9, 2025
6 checks passed
@sonroyaalmerol sonroyaalmerol deleted the add-more-tests branch February 9, 2025 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant