Minor interface improvements and fix bug writing Python spec file #140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes it easier to run xija_gui_fit for model spec files taken from the Ska data
chandra_models
repo:--model-version
to pick a particular version.acisfp_spec_matlab
were not allowed because it automatically appended_spec
to the model name. Now it tries both the original model name and one with_spec
appended. Doing that appending was a mistake, but it is left there for back-compatibility.In addition this fixes a bug when writing out the Python script that will generate a spec file.
Interface impacts
Testing
Unit tests
Independent check of unit tests by [REVIEWER NAME]
Functional tests
Application help showing new option:
Full model spec file name (acisfp_spec_matlab) with default (latest) version.
Shortened model spec name (acisfp => acisfp_spec) with non-default version
Save model to Python
First start xija_gui_fit with:
Then save the model as Python to
acisfp_spec_3.60.py
. Then run that file to remake the spec file. Previously this failed with a SyntaxError.