Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved implementation for pars_dict and pars attributes + pickle test #145

Merged
merged 1 commit into from
Feb 2, 2025

Conversation

taldcroft
Copy link
Member

@taldcroft taldcroft commented Jan 30, 2025

Description

This improves on the fix from #142 using cached_property to define the pars_dict and pars properties with defaults as {} and [] respectively.

It also fixes poor coding style for a couple of properties.

This is not needed for Ska3 2025.1, it can go in a later release.

Interface impacts

Testing

Unit tests

  • Mac
(ska3-flight-2025.0rc2) ➜  xija git:(recursion-redux) git rev-parse --short HEAD
39633c7
(ska3-flight-2025.0rc2) ➜  xija git:(recursion-redux) pytest xija
===================================================== test session starts ======================================================
platform darwin -- Python 3.12.8, pytest-8.3.4, pluggy-1.5.0
rootdir: /Volumes/git
configfile: pytest.ini
plugins: doctestplus-1.3.0, anyio-4.7.0, timeout-2.3.1
collected 44 items                                                                                                             

xija/tests/test_get_model_spec.py .......                                                                                [ 15%]
xija/tests/test_models.py .....................................                                                          [100%]

===================================================== 44 passed in 34.85s ======================================================

Independent check of unit tests by [REVIEWER NAME]

  • [PLATFORM]:

Functional tests

(ska3-flight-2025.0rc2) ➜  xija git:(recursion-redux) python -m xija.gui_fit.app acisfp_spec_matlab --stop 2025:001

This worked as expected, in particular fitting succeeded.

@taldcroft taldcroft merged commit ea3f00e into master Feb 2, 2025
@taldcroft taldcroft deleted the recursion-redux branch February 2, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants