Index analysis refactor #1 #1781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch for jenkins? |
b-scholz
reviewed
Dec 1, 2020
b-scholz
previously approved these changes
Dec 1, 2020
|
The source tests do not work. Can you fix this? You can check this by typing |
Codecov Report
@@ Coverage Diff @@
## master #1781 +/- ##
=======================================
Coverage 80.57% 80.57%
=======================================
Files 398 398
Lines 25128 25137 +9
=======================================
+ Hits 20246 20255 +9
Misses 4882 4882
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Jenkins, test this please |
added 2 commits
December 2, 2020 16:31
…7/souffle into index-analysis-refactor
b-scholz
approved these changes
Dec 3, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first in a series of pull requests to refactor the index analysis code.
In this PR we make the MinIndexSelection class internal to the IndexAnalysis. Therefore, all consumers of MinIndexSelection now depend on the IndexAnalysis instead which calls the corresponding methods on the MinIndexSelection class.
@b-scholz