CSE Machine: Implement two-step block statement evaluation #1538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7948778469Details
💛 - Coveralls |
* Restore whitespace for readability * Refactor if-else to use early return instead * Standardize capitalization of comments * Update comment for clarity
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements two-step block statement evaluation for the CSE machine.
This is done by introducing a new subtype of
BlockStatementcalledRawBlockStatementto indicate a block statement that has completed environment creation, and only needs to get its body unpacked into the control stack.Resolves #1537.
Changes
RawBlockStatementRawBlockStatementinstead of unpacking directly