Do not recurse into ignored directories. #294
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When generating the tar.gz for local previews can skip recursively processing them. This potentially saves a lot of processing time by removing the stat calls to the files contained in them. This tends to be the case for node_modules and other commonly ignored paths. On my internal git repo running on macos this results in a -82% change into the to generate the tar.tz. ``` $ time spacectl stack local-preview --id test --no-upload 151.33 secs $ time ~/src/spacectl/spacectl stack local-preview --id test --no-upload 26.32 secs ``` I also checked if the same files were included in both tar.gz files. ``` $ tar -tf ~/old.tar.gz | sed 's|[^/]*||' | shasum 82510ad099d3eb9e3c1bba906b8b8dff00c802aa - $ tar -tf ~/new.tar.gz | sed 's|[^/]*||' | shasum 82510ad099d3eb9e3c1bba906b8b8dff00c802aa - ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating the tar.gz for local previews can skip recursively processing them. This potentially saves a lot of processing time by removing the stat calls to the files contained in them. This tends to be the case for node_modules and other commonly ignored paths.
On my internal git repo running on macos this results in a -82% change to the time to generate the tar.tz.
I also checked if the same files were included in both tar.gz files.
Fixes: #289