allowInMethodsWithAttributes does not work on method parameters

[ruudk]

I noticed an issue.

return [
    'parameters' => [
        'disallowedClasses' => [
            [
                'allowInUse' => true,
                'class' => 'EventRecorder',
                'errorTip' => 'Only allowed in command handlers. Inject the EventBus in subscribers.',
                'allowInMethodsWithAttributes' => [
                    AsCommandHandler::class,
                ]
            ],
        ],
    ],
];

final readonly class SomeHandler
{
    #[AsCommandHandler]
    public function __invoke(SomeCommand $command, Actor $actor, EventRecorder $eventRecorder) : void // error
    {
        $eventRecorder = new EventRecorder(); // allowed
    }
}

Class EventRecorder is forbidden.
💡 Only allowed in command handlers. Inject the EventBus in subscribers.
🔖 disallowed.class
↳ src/SomeHandler.php:4

So within the class it works, but not on the signature. That should be considered "within the method" to me?

[spaze]

Huh, I guess this should be supported, let me check why it's not the case.

[spaze]

Hey @ruudk, I think I have added the support for "classes in signature are within the method", but would like to ask you for help verifying the "fix". It is sort of a not straightforward fix because it seems that PHPStan is missing a way to get a method reflection from the namespace node in the signature, or at least I can't find it, so I had to emulate it.

Would you please try and run the code from #315 and see 1) it works as expected, 2) it doesn't break anything?

[ruudk]

Just tested it out and it works as expected! 🎉 Thanks!

[spaze]

Thanks for testing! I've now released the fix in 4.4.1.