Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using sleep command #100

Merged
merged 1 commit into from
Dec 19, 2022
Merged

Stop using sleep command #100

merged 1 commit into from
Dec 19, 2022

Conversation

MarcosDY
Copy link
Contributor

Signed-off-by: Marcos Yacob marcos.yacob@hpe.com

@MarcosDY
Stop using sleep command on quickstart client
73c01c9 
Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com>
rturner3
rturner3 approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@rturner3 rturner3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also deploy this in the test script so that CI exercises this YAML.

@MarcosDY
Copy link
Contributor Author

agree we must validate client, I created an issue and I'll merge this changes for now, to make it works again

@MarcosDY MarcosDY merged commit 1760207 into spiffe:main Dec 19, 2022
@MarcosDY MarcosDY deleted the remove-sleep-cmd-from-client branch December 19, 2022 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rturner3 rturner3 rturner3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcosDY @rturner3