Remove the deprecated k8s_sat node attestor plugin #5703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c0d3-k1ra
requested review from
evan2645,
amartinezfayo,
azdagron,
MarcosDY and
rturner3
as code owners
c0d3-k1ra
force-pushed
the
remove-k8ssat-plugin
branch
4 times, most recently
from
717e051 to
85d4866
Compare
c0d3-k1ra
force-pushed
the
remove-k8ssat-plugin
branch
from
85d4866 to
de327d5
Compare
|
The code changes in this PR look appropriate, however I think we will want to hold off on merging this until a minor release (next scheduled is v1.12.0 in mid-February) and when all these related issues have been resolved: #5681 (comment) |
|
Hi @c0d3-k1ra, there is now a merge conflict in this PR. Would you be able to address this? |
sorindumitru
force-pushed
the
remove-k8ssat-plugin
branch
from
dc3991a to
d316d78
Compare
sorindumitru
previously approved these changes
Mar 11, 2025
Signed-off-by: Amit Upadhyay <amit.upadhyay021@outlook.com>
sorindumitru
force-pushed
the
remove-k8ssat-plugin
branch
from
d316d78 to
a4d9db2
Compare
amartinezfayo
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check list
Affected functionality
This PR closes #5681. It removes the deprecated k8s_sat plugin from the repository.
Description of change
This PR removes the files associated with k8s_sat node attestor plugin as it has been deprecated since [1.9.0] - 2024-02-22
Which issue this PR fixes
fixes #5681