Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump wasmtime to 3.0.0 #917

Merged
merged 1 commit into from
Nov 29, 2022
Merged

Bump wasmtime to 3.0.0 #917

merged 1 commit into from
Nov 29, 2022

Conversation

etehtsea
Copy link
Contributor

@etehtsea etehtsea commented Nov 27, 2022 •
edited
Loading

Signed-off-by: Konstantin Shabanov mail@etehtsea.me

@itowlson itowlson requested review from lann and dicej November 27, 2022 19:22
lann
lann approved these changes Nov 29, 2022
View reviewed changes
Copy link
Collaborator

@lann lann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@etehtsea etehtsea marked this pull request as ready for review November 29, 2022 18:15
@etehtsea
Bump wasmtime to 3.0.0
87fc3a0 
Fixes compatibility with redesigned error handling (Result<T,
wasmtime::Trap> -> anyhow::Result<T>).

Refs: bytecodealliance/wasmtime#5149

Signed-off-by: Konstantin Shabanov <mail@etehtsea.me>
@itowlson itowlson merged commit 2d54bd1 into spinframework:main Nov 29, 2022
@etehtsea etehtsea deleted the wasmtime-3 branch December 16, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lann lann lann approved these changes

@dicej dicej Awaiting requested review from dicej

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@etehtsea @lann @itowlson